perf: improve MarkerComposable rendering performance - #881
Open
brucemok8 wants to merge 3 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
brucemok8
force-pushed
the
perf/improves-marker-composable-rendering-performance
branch
from
March 27, 2026 05:11
6bec4de to
f9ba7e5
Compare
kikoso
force-pushed
the
perf/improves-marker-composable-rendering-performance
branch
from
April 9, 2026 13:57
20cd3ba to
b24b74a
Compare
reverted pushing renderComposableToBitmapDescriptor call to IO thread as causing intermittent crash
dkhawk
force-pushed
the
perf/improves-marker-composable-rendering-performance
branch
from
August 18, 2026 22:17
b24b74a to
bdf161f
Compare
…eView lifecycle Add an interactive performance demonstration for MarkerComposable and polish offscreen rendering lifecycle details on top of googlemaps#881. - Add MarkerComposablePerformanceActivity showcasing 10-75 dynamic markers with 1Hz and 4Hz auto-update stress testing. - Add an explanatory dialog clarifying marker IDs vs live state counters and demo controls. - Ensure pixel-perfect alignment for marker badge typography by disabling font padding and using vector icons. - Delegate setContent dynamically via { currentContent() } in rememberComposeBitmapDescriptor so retained ComposeViews reflect updated state on recomposition. - Set alpha = 0f on retained ComposeViews to prevent offscreen rendering views from appearing in the window root layout.
dkhawk
force-pushed
the
perf/improves-marker-composable-rendering-performance
branch
from
August 18, 2026 23:08
659044a to
7a57048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the rendering performance of
MarkerComposable, particularly when displaying a larger number of markers with frequently updating content.Changes
ComposeViewinstances instead of creating and disposing them for each render. The view is retained and used to generate updated bitmaps when marker keys change, and disposed only when the marker is removed.rememberComposeBitmapDescriptorto return a nullable type. Callers skip rendering until the bitmap is ready, preventing main thread blocking and allowing markers to appear asynchronously.Impact
These changes significantly reduce UI jank during marker updates. In testing, scenarios with ~25 dynamically updating markers show noticeably smoother performance.